Fix ThreadPool for DistributedSink and use StrongTypedef for CurrentMetrics/ProfileEvents/StatusInfo to avoid further errors #48314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azat
changed the title
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
build/strong-typedefs
branch
from
e7c69ba
to
1794505
Compare
tavplubix
approved these changes
Apr 1, 2023
tavplubix
added
pr-bugfix
robot-clickhouse
added a commit
that referenced
this pull request
Apr 2, 2023
…trongTypedef for CurrentMetrics/ProfileEvents/StatusInfo to avoid further errors
robot-clickhouse-ci-1
added
the
pr-backports-created
tavplubix
added a commit
that referenced
this pull request
Apr 2, 2023
Backport #48314 to 23.3: Fix ThreadPool for DistributedSink and use StrongTypedef for CurrentMetrics/ProfileEvents/StatusInfo to avoid further errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
ThreadPoolforDistributedSink(INSERTintoDistributed) and useStrongTypedefforCurrentMetrics/ProfileEvents/StatusInfoto avoid further errorsNote, that initial PR included into 23.3 release, so it should be backported to 23.3, also maybe it worth to backport only the first part from this PR (9e15b6517c5ae6c3d552f09c33e8149a28ca1a00, 6a272cb0fbf66f0da6e49a2d2d12d6bde2180ee3) to keep patches for backport as simple as possible, @tavplubix what do you think about this?
Follow-up for: #47880 (cc @alexey-milovidov @tavplubix )